BinaryBuilder

[juan-pablo-vielma]

No description provided.

[codecov-io]

Codecov Report

Merging #76 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   92.05%   92.05%           
=======================================
  Files           4        4           
  Lines         428      428           
=======================================
  Hits          394      394           
  Misses         34       34

Impacted Files	Coverage Δ
src/MPBWrapper.jl	94.36% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2359497...a146fbd. Read the comment docs.

[mlubin]

What was the reason for downgrading from 2.0.6 to 2.0.5?

[mlubin]

Could you try deleting the special case for Windows here:
https://github.com/JuliaOpt/ECOS.jl/blob/23594975c8506bf4905b24120b0dd360aa9e24be/test/MPBWrapper.jl#L27-L34
and here:
https://github.com/JuliaOpt/ECOS.jl/blob/23594975c8506bf4905b24120b0dd360aa9e24be/test/MOIWrapper.jl#L28-L33

They should both work now with the new binaries.

[mlubin]

Failures on 32-bit windows are pointing to a bug that was masked because we had disabled the tests. I think removing the Vector{Int} assertion on the line below should fix it?
https://github.com/JuliaOpt/ECOS.jl/blob/23594975c8506bf4905b24120b0dd360aa9e24be/src/MPBWrapper.jl#L268

[mlubin]

The failure on win64/julia 1.0 is pre-existing (https://ci.appveyor.com/project/JuliaOpt/ecos-jl/build/1.0.63/job/55m6ej3fxqoony62), so this is safe to merge from my side.