Update deprecated_constants.jl #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 83.58% 84.92% +1.34%
==========================================
Files 9 9
Lines 1553 1698 +145
==========================================
+ Hits 1298 1442 +144
- Misses 255 256 +1
Continue to review full report at Codecov.
|
|
Can we not just update the Convex.jl tests? |
|
Oh, true. I actually didn't realize we were using the deprecated setting explicitly there, for some reason I thought it was getting set somewhere else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the Convex.jl tests spams like 100+ of these messages. Setting
maxlog=1should help by having it only print once. An alternative would be to useBase.depwarnto make it an actual deprecation warning which will only show up in tests or if you start julia with--depwarn=yes(on Julia 1.5+; it shows by default on earlier versions, I think), and only print once.