-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOI to 0.10 #754
MOI to 0.10 #754
Conversation
thanks @matbesancon! for some reason I don't get email notifications so I didn't see this, but go ahead and merge if it's finished! I added you as a collaborator. also maybe merge #753 at the same time as this PR if they are related |
Thanks! This PR replaces #753, I don't think maintaining the two versions of MOI at the same time is feasible |
I'm currently doing it on the SCIP wrapper, should have grasped it enough to transfer it to Hypatia soon |
OK this seems to be working, it might be worth it to check more MOI tests but most of those that were in the old tests are running now |
The error happening is in JuMP, I guess this is linked to JuMP not being updated to MOI 0.10? |
also the next blocker will be up-ing PolyJuMP to MOI 0.10 |
Still blocked by JuliaAlgebra/DynamicPolynomials.jl#101 which blocks depenencies up to PolyJuMP |
should be good now 🤞 |
talked too quickly, still blocked by SOS |
I reran but it failed again. JuMP is failing to precompile:
|
my guess is it's installing an old version of JuMP? because src/writers.jl doesn't exist anymore in JuMP |
OK yeah we need PolyJuMP and SumOfSquares to both work with JuMP 0.22 and be tagged. @blegat looks like SumOfSquares JuMP compat is not at 0.22 yet |
PolyJuMP is waiting for a new release but master works now |
and yes SumOfSquare will need to also get this release from PolyJuMP |
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
- Coverage 91.95% 91.93% -0.02%
==========================================
Files 54 54
Lines 8325 8324 -1
==========================================
- Hits 7655 7653 -2
- Misses 670 671 +1
Continue to review full report at Codecov.
|
runtests is now passing because I split the examples testing out, so the runtests deps don't include the lagging sumofsquares etc. but examples tests are still failing because of those deps |
I'm going to merge despite examples failing because it's unclear how long we'll have to wait for the dependencies |
Bump MOI to 0.10.
I fixed the obvious issues, the tests might still be a pain
Edit: since Hypatia does not use MOI.Test, this should be fine