Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect NLP and revive HS tests #1223

Merged
merged 1 commit into from
Apr 8, 2018
Merged

connect NLP and revive HS tests #1223

merged 1 commit into from
Apr 8, 2018

Conversation

mlubin
Copy link
Member

@mlubin mlubin commented Apr 8, 2018

Ipopt at jump-dev/Ipopt.jl#108 passes the nlp_solver tests except that:

Maybe we don't need to test direct mode here, but it was useful for debugging.

@codecov
Copy link

codecov bot commented Apr 8, 2018

Codecov Report

Merging #1223 into master will decrease coverage by 0.13%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1223      +/-   ##
==========================================
- Coverage   78.89%   78.75%   -0.14%     
==========================================
  Files          24       24              
  Lines        3406     3413       +7     
==========================================
+ Hits         2687     2688       +1     
- Misses        719      725       +6
Impacted Files Coverage Δ
src/nlp.jl 78.64% <0%> (-0.66%) ⬇️
src/optimizerinterface.jl 70.58% <50%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05b917...3120708. Read the comment docs.

@mlubin mlubin mentioned this pull request Apr 8, 2018
@mlubin mlubin merged commit 9e2cad7 into master Apr 8, 2018
@mlubin mlubin deleted the ml/nlp branch April 8, 2018 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant