First pass of printing for MOI constraints. #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1389 +/- ##
=========================================
+ Coverage 89.55% 89.8% +0.24%
=========================================
Files 25 25
Lines 3429 3541 +112
=========================================
+ Hits 3071 3180 +109
- Misses 358 361 +3
Continue to review full report at Codecov.
|
IainNZ
approved these changes
Jul 29, 2018
src/print.jl
Outdated
|
|
||
| #------------------------------------------------------------------------ | ||
| ## Model | ||
| #------------------------------------------------------------------------ | ||
| function Base.show(io::IO, m::Model) # TODO temporary | ||
| function Base.show(io::IO, model::Model) # TODO temporary |
There was a problem hiding this comment.
Nit: attach the TODO to the issue?
src/print.jl
Outdated
| var_name = name(v) | ||
| if !isempty(var_name) | ||
| # TODO: This is wrong if variable name constains extra "]" | ||
| return math(replace(replace(var_name,"[","_{",1),"]","}"), mathmode) | ||
| return replace(replace(var_name,"[","_{",1),"]","}") |
There was a problem hiding this comment.
Style: spaces between arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feels like I've untangled the printing rat's nest. JuMP
ConstraintRefobjects now print out the underlying constraint. There's obvious room for improvement, especially in how constraint sets print out (like, print fancy versions in IJulia). See the tests for example of what the print-out looks like. I also print the constraint name if it's non-empty.Does not yet resolve the issue #1180 because we need to decide what model printing should look like. Based on #957 we might want to print a summary by default and have another method to get the extensive-form print-out of the model.
@IainNZ, care to review since you did most of the original printing work?