Use DenseDict for copy_to #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we use the same code as in CleverDicts? |
|
The use case is a bit different. Here, even if we know the variable indices are from |
joaquimg
reviewed
Jul 11, 2020
| Base.length(d::DenseDict) = length(d.set) | ||
| Base.haskey(dict::DenseDict, key) = dict.hash(key) in dict.set | ||
| Base.getindex(dict::DenseDict, key) = dict.map[dict.hash(key)] | ||
| function Base.setindex!(dict::DenseDict, value, key) |
There was a problem hiding this comment.
what happens if one goes beyond the limit?
should it resize automatically? or even use sizehint?
There was a problem hiding this comment.
Currently it's an error, we can revisit once we have a use case for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no variable was deleted, the variable indices are contiguous from 1 to
nso we can store the mapping in aVectorinstead of aDict. This PR allows to exploit it.The field of
IndexMapis now aUnionof 2 concrete types. This gives the cost of aifwhen accessing the field which is smaller than the cost of hashing an index. Moreover, if the index map is going to be accessed a lot, a function barrier can be used to even avoid the cost of thisif.