Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call final_touch in optimize in CachingOptimizer #1754

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Call final_touch in optimize in CachingOptimizer #1754

merged 3 commits into from
Feb 25, 2022

Conversation

blegat
Copy link
Member

@blegat blegat commented Feb 23, 2022 •
edited
Loading

This allows to use a CachingOptimizer with a MatrixOfConstraint cache with the workflow: add_variable, add_constraint, optimize.

  • Test

@blegat blegat added the Submodule: Utilities About the Utilities submodule label Feb 23, 2022
@blegat blegat mentioned this pull request Feb 23, 2022
Merged
4 tasks
odow
odow reviewed Feb 23, 2022
View reviewed changes
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't tested a lot of this, because I don't think we envisaged MatrixOfConstraints supporting an incremental build.

@blegat blegat force-pushed the bl/optimizer_final_touch branch from 797d43f to 2029ec7 Compare February 24, 2022 15:01
@odow odow merged commit 63ee291 into master Feb 25, 2022
@odow odow deleted the bl/optimizer_final_touch branch February 25, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow left review comments

Assignees
No one assigned
Labels
Submodule: Utilities About the Utilities submodule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blegat @odow