Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Utilities] remove keyword arguments from copy_to #2272

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[Utilities] remove keyword arguments from copy_to #2272

merged 1 commit into from
Sep 19, 2023

Conversation

odow
Copy link
Member

@odow odow commented Sep 19, 2023

No description provided.

@blegat
Copy link
Member

blegat commented Sep 19, 2023 •
edited
Loading

Wait, I thought it was removed already. We deprecated and kept it for backward compatibility ? Are there warning if anyone was using it ?

@odow
Copy link
Member Author

odow commented Sep 19, 2023

I think these ones I just missed removing. If you tried to use them they'd error (default_copy_to doesn't accept kwargs).

@odow odow merged commit 763145d into master Sep 19, 2023
16 checks passed
@odow odow deleted the od/copy-to-kwargs branch September 19, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odow @blegat