[Utilities] fix adding unsupported constraints to AbstractModel #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blegat
reviewed
Oct 30, 2024
Co-authored-by: Benoît Legat <[email protected]>
|
Ah, I understand better your other PR now, it's not such a nasty bug. But I wouldn't say it was expected behavior that we were permissive by letting |
blegat
approved these changes
Oct 30, 2024
|
Yeah it's a case of "things worked when they shouldn't have." It also never came up in practice at the JuMP level, because we always copy to a file format with bridges, and they checked appropriately. |
odow
commented
Oct 30, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2570
Closes #2571
This PR is an alternative to #2571