Simplify test_conic_linear with forced bridging #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Dec 17, 2024
| _test_conic_linear_helper(model, config, false) | ||
| config::Config{T}, | ||
| ) where {T} | ||
| test_conic_linear_VectorOfVariables(MOI.Bridges.Constraint.VectorFunctionize{T}(model), config) |
There was a problem hiding this comment.
No. Because we can't nest SingleBridgeOptimizer and LazyBridgeOptimizer.
odow
requested changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of these helpers could be simplified with
SingleBridgeOptimizer. What we are doing is basically hardcoding a bridge so adding aSingleBridgeOptimizerwould be equivalent since this bridge optimizer layer always applies the bridge, even if the constraint is supported (which is why I call it forced bridging).This PR just does it for one test as a proof of concept.