Use copy instead of deepcopy in MOIU model #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
approved these changes
Nov 12, 2018
src/Utilities/model.jl
Outdated
| @@ -270,10 +270,11 @@ function MOI.add_constraint(model::AbstractModel, f::F, s::S) where {F<:MOI.Abst | |||
| if MOI.supports_constraint(model, F, S) | |||
| # We give the index value `nextconstraintid + 1` to the new constraint. | |||
| # As the same counter is used for all pairs of F-in-S constraints, | |||
| # the index value is unique across all constraint types as mentionned in `@model`'s doc. | |||
| # the index value is unique across all constraint types as mentionned in | |||
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 95.67% 95.67% +<.01%
==========================================
Files 47 47
Lines 4830 4834 +4
==========================================
+ Hits 4621 4625 +4
Misses 209 209
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the benchmark of #566 (comment):
Before this PR:
After this PR:
Closes #566