Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support solve_time(model) #56

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Support solve_time(model) #56

merged 3 commits into from
Mar 28, 2023

Conversation

remi-garcia
Copy link
Contributor

@remi-garcia remi-garcia commented Mar 27, 2023

Currently, solve_time call is passed to the solver and the returned time corresponds to the last optimization only.

  • Need to add some tests

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (aa7bb35) 96.05% compared to head (76e4e56) 96.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   96.05%   96.08%   +0.02%     
==========================================
  Files           8        8              
  Lines         786      791       +5     
==========================================
+ Hits          755      760       +5     
  Misses         31       31              
Impacted Files Coverage Δ
src/MultiObjectiveAlgorithms.jl 91.66% <100.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@odow
Copy link
Member

odow commented Mar 27, 2023

Nice catch

@odow odow marked this pull request as ready for review March 27, 2023 23:40
test/test_model.jl Outdated Show resolved Hide resolved
@odow odow merged commit 311d5d2 into jump-dev:master Mar 28, 2023
@remi-garcia remi-garcia deleted the patch-1 branch March 28, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants