Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOI 1.0 #159

Merged
merged 3 commits into from
Feb 25, 2022
Merged

MOI 1.0 #159

merged 3 commits into from
Feb 25, 2022

Conversation

joaquimg
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #159 (58c1e44) into master (a9bc4e0) will increase coverage by 1.09%.
The diff coverage is n/a.

❗ Current head 58c1e44 differs from pull request most recent head fe005cf. Consider uploading reports for the commit fe005cf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   54.46%   55.55%   +1.09%     
==========================================
  Files           9        9              
  Lines        4030     4156     +126     
==========================================
+ Hits         2195     2309     +114     
- Misses       1835     1847      +12     
Impacted Files Coverage Δ
src/Xpress.jl 85.71% <0.00%> (-14.29%) ⬇️
src/license.jl 65.95% <0.00%> (-3.61%) ⬇️
src/MOI/MOI_wrapper.jl 86.81% <0.00%> (+0.11%) ⬆️
src/MOI/MOI_callbacks.jl 86.48% <0.00%> (+0.37%) ⬆️
src/helper.jl 42.23% <0.00%> (+1.09%) ⬆️
src/api.jl 24.46% <0.00%> (+1.15%) ⬆️
src/xprs_callbacks.jl 62.74% <0.00%> (+2.32%) ⬆️
src/lib.jl 15.63% <0.00%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bc4e0...fe005cf. Read the comment docs.

@joaquimg
Copy link
Member Author

@odow I noted you still want to do "things" in gurobi em cplex. Should we consider some "things" for xpress?

@odow
Copy link
Member

odow commented Feb 25, 2022

Gurobi and CPLEX still have excluded tests, like the infeasibility certificate stuff. And they're missing a copy-to thing. I also don't know if we should tag a 1.0 without official support. (It's an incentive. Hey, your software is still in beta)

@joaquimg
Copy link
Member Author

I would be fine not tagging this as 1.0

Project.toml Outdated Show resolved Hide resolved
@joaquimg joaquimg merged commit 9790646 into master Feb 25, 2022
@odow odow deleted the jg/moi1 branch April 5, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants