-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore logging for OS other than Windows #167
Conversation
addresses #166 |
@joaquimg I guess that a maintainer will have to run the tests in order to get the secret for the Xpress license? |
Yes. Can you instead post a screenshot of the tests passing? And perhaps solving a model with logging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'll wait for @joaquimg to check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Did you test on linux?
if Sys.iswindows() && # is win | ||
model.inner.logfile == "" && # no file -> screen | ||
model.log_level != 0 # has log | ||
if model.inner.logfile == "" && # no file -> screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux also requires this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to FICO:
Prior to Xpress 8.9, the Optimizer library would automatically print messages to stdout for all Unix-like platforms
(including MacOS) if no message callback function was defined. With Xpress 8.9 and later, the Optimizer library will no longer print messages automatically for any platform.To print the messages produced by the Optimizer, a user should set a message callback, using XPRSaddcbmessage():
and provide it with a function that prints each message to stdout, as in the example provided in the link above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if you add:
os: [ubuntu-latest, windows-latest, macOS-latest]
to the CI? Then all major platforms will be tested automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux also requires this?
Short answer: yes.
@joaquimg It's working on Xpress 8.11 on Linux too |
and update control parameters for latest FICO Xpress release 8.14.0