Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic tidying of code #213

Closed
wants to merge 3 commits into from
Closed

Basic tidying of code #213

wants to merge 3 commits into from

Conversation

odow
Copy link
Member

@odow odow commented Feb 21, 2024

  • Remove unreachable VERSION blocks
  • Remove uneeded imports
  • Unify package imports

@odow
Copy link
Member Author

odow commented Feb 21, 2024

Ah. Now the CI license has expired. @joaquimg do you have a contact at FICO who supplied it?

@odow odow mentioned this pull request Feb 21, 2024
Closed
@odow odow closed this Feb 28, 2024
@odow odow reopened this Feb 28, 2024
@odow
Basic tidying of code
6d38c94 
 * Remove unreachable VERSION blocks
 * Remove uneeded imports
 * Unify package imports
@odow odow changed the base branch from master to od/use-conda-binaries February 29, 2024 03:39
@codecov Codecov
Copy link

codecov bot commented Feb 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.23%. Comparing base (30d7841) to head (ed333bd).
Report is 1 commits behind head on od/use-conda-binaries.

Files Patch % Lines
src/MOI/MOI_wrapper.jl 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@                    Coverage Diff                    @@
##           od/use-conda-binaries     #213      +/-   ##
=========================================================
+ Coverage                  49.67%   50.23%   +0.56%     
=========================================================
  Files                          9        9              
  Lines                       4815     4815              
=========================================================
+ Hits                        2392     2419      +27     
+ Misses                      2423     2396      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow mentioned this pull request Mar 7, 2024
Merged
@odow
Copy link
Member Author

odow commented Mar 7, 2024

Closing in favor of #222

@odow odow closed this Mar 7, 2024
@odow odow deleted the od/tidy branch March 7, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@odow