Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to src/api.jl #236

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Remove calls to src/api.jl #236

merged 3 commits into from
Mar 13, 2024

Conversation

odow
Copy link
Member

@odow odow commented Mar 13, 2024

We don't have to remove it for a while, but I'd like the code to not call src/api.jl.

test/runtests.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.78%. Comparing base (2af6c9a) to head (3a9acaa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   63.07%   62.78%   -0.29%     
==========================================
  Files           8        8              
  Lines        3550     3550              
==========================================
- Hits         2239     2229      -10     
- Misses       1311     1321      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Mar 13, 2024

Success. My goal is to slowly bump up the coverage of the other files, moving any necessary functions to src/api.jl.

image

@odow odow merged commit 232bd38 into master Mar 13, 2024
6 of 7 checks passed
@odow odow deleted the od/api branch March 13, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant