Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XPRS_OPTIMIZETYPEUSED instead of is_mip #256

Closed
wants to merge 1 commit into from

Conversation

odow
Copy link
Member

@odow odow commented Mar 25, 2024

So it seems like this might actually need Xpress v9, so we should have a discussion about which versions we should support before merging

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 67.87%. Comparing base (ceb9df8) to head (fa85401).

Files Patch % Lines
src/MOI/MOI_wrapper.jl 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   67.88%   67.87%   -0.02%     
==========================================
  Files           6        6              
  Lines        3304     3309       +5     
==========================================
+ Hits         2243     2246       +3     
- Misses       1061     1063       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member Author

odow commented Mar 26, 2024

Closing because this requires v9, and many users are still on v8.

@odow odow closed this Mar 26, 2024
@odow odow deleted the od/optimize-type-used branch March 26, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant