Revert use of Cstring to Ptr{UInt8}

[odow]

@joaquimg could you try this one out? Let me know if you're using Cstring anywhere.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (5f45fb2) to head (d64eb6f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   67.93%   67.91%   -0.02%     
==========================================
  Files           6        6              
  Lines        3303     3301       -2     
==========================================
- Hits         2244     2242       -2     
  Misses       1059     1059              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odow]

We could also drop the Cchar => UInt8 replacement, but that's a bit more breaking (because we use UInt8('B') explicitly in places) for minimal upside.

julia> Cchar
Int8

[joaquimg]

I think we can test until friday

[joaquimg]

this broke all our lic checks that relied on the userlic function

[odow]

Let's just leave it then. The generator script is a bit annoying, but it's written now.