Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on OpenBSD with --listen option #3481

Closed
5 of 10 tasks
lcheylus opened this issue Oct 16, 2023 · 0 comments · Fixed by #3483
Closed
5 of 10 tasks

Crash on OpenBSD with --listen option #3481

lcheylus opened this issue Oct 16, 2023 · 0 comments · Fixed by #3483

Comments

@lcheylus
Copy link
Contributor

  • I have read through the manual page (man fzf)
  • I have the latest version of fzf
  • I have searched through the existing issues

Info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • OpenBSD
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

Crash on OpenBSD 7.4/current version on amd64 with -listen option:

$ fzf --version
0.43.0
$ fzf --listen
Abort trap (core dumped)

In my kernel logs: fzf[9961]: pledge "inet", syscall 97

According to OpenBSD protector code src/protector/protector_openbsd.go, syscall for inet is not defined to permit HTTP server on network.

I will submit a PR to fix this issue.

Thanks to @semarie for reporting this issue to me.
lcheylus added a commit to lcheylus/fzf that referenced this issue Oct 16, 2023
@lcheylus
Fix crash on OpenBSD with --listen
a01cc2c 
  - src/protector/protector_openbsd.go: add inet permissions for pledge
  - fix junegunn#3481

Signed-off-by: Laurent Cheylus <[email protected]>
@lcheylus lcheylus mentioned this issue Oct 16, 2023
Merged
junegunn pushed a commit that referenced this issue Oct 16, 2023
@lcheylus
Fix crash on OpenBSD with --listen (#3483)
d51b71e 
- src/protector/protector_openbsd.go: add inet permissions for pledge
  - fix #3481

Signed-off-by: Laurent Cheylus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash on OpenBSD with --listen lcheylus/fzf
1 participant
@lcheylus