-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add border-native
option to --tmux
flag
#4157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aead
changed the title
add
add Jan 3, 2025
native-border
option to --tmux
flagborder-native
option to --tmux
flag
This commit adds the `border-native` resulting in the following: ``` --tmux[=[center|top|bottom|left|right][,SIZE[%]][,SIZE[%]][,border-native]] ``` By default, when not specified, the `-B` flag is passed to the `tmux popup-window` command such that no border is drawn around the tmux popup window. When the `border-native` option is present the `-B` flag is omitted and the popup window is drawn using the border style configured in the tmux config file. Fixes #4156 Signed-off-by: Andreas Auernhammer <[email protected]>
aead
force-pushed
the
tmux-border-option
branch
from
January 3, 2025 15:17
dc73b93
to
fb16c09
Compare
junegunn
reviewed
Jan 3, 2025
junegunn
reviewed
Jan 3, 2025
Signed-off-by: Andreas Auernhammer <[email protected]>
junegunn
reviewed
Jan 3, 2025
junegunn
reviewed
Jan 3, 2025
Signed-off-by: Andreas Auernhammer <[email protected]>
For more consistent look
I updated the branch to prepend fzf --tmux
fzf --tmux border-native
fzf --tmux --list-border
fzf --tmux border-native --list-border One gotcha is that the extra margin is not colored when you use a non-default background color, but I don't think it's a critical problem. fzf --tmux --color bg:#ff0000
fzf --tmux border-native --color bg:#ff0000
fzf --tmux border-native --color bg:#ff0000 --margin 0 |
junegunn
approved these changes
Jan 4, 2025
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the
border-native
resulting inthe following:
By default, when not specified, the
-B
flag is passed to thetmux popup-window
command such that no border is drawn aroundthe tmux popup window.
When the
border-native
option is present the-B
flag is omittedand the popup window is drawn using the border style configured in
the tmux config file.
Fixes #4156