Methods/constructors invoked via ExecutableInvoker should have access to current ExtensionContext and ExtensionRegistry

[marcphilipp]

Discussed in #3896

^{Originally posted by alanwong-toast July 22, 2024}
I was hoping that ExecutableInvoker (accessible from ExtensionContext) would allow for the invocation of methods/classes with the currently known set of ParameterResolvers, but based on my testing, it seems that it only loads with a default set of resolvers and never the resolvers I have injected.

The creation of the DefaultExecutableInvoker happens here:

junit5/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/ClassBasedTestDescriptor.java

Lines 149 to 151 in ae20d63

	public JupiterEngineExecutionContext prepare(JupiterEngineExecutionContext context) {
	MutableExtensionRegistry registry = populateNewExtensionRegistryFromExtendWithAnnotation(
	context.getExtensionRegistry(), this.testClass);

junit5/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/ClassBasedTestDescriptor.java

Lines 179 to 192 in ae20d63

	ThrowableCollector throwableCollector = createThrowableCollector();
	ExecutableInvoker executableInvoker = new DefaultExecutableInvoker(context);
	ClassExtensionContext extensionContext = new ClassExtensionContext(context.getExtensionContext(),
	context.getExecutionListener(), this, this.lifecycle, context.getConfiguration(), throwableCollector,
	executableInvoker);
	// @formatter:off
	return context.extend()
	.withTestInstancesProvider(testInstancesProvider(context, extensionContext))
	.withExtensionRegistry(registry)
	.withExtensionContext(extensionContext)
	.withThrowableCollector(throwableCollector)
	.build();
	// @formatter:on

With this constructor for DefaultExecutableInvoker:

junit5/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/execution/DefaultExecutableInvoker.java

Lines 40 to 42 in ae20d63

	public DefaultExecutableInvoker(JupiterEngineExecutionContext context) {
	this(context.getExtensionContext(), context.getExtensionRegistry());
	}

It appears that the new extension registry generated from populateNewExtensionRegistryFromExtendWithAnnotation at the top is never passed into the new context that is used to construct the class's context.

This results in a default set of resolvers in all cases, regardless of which extension interface I use to get the extension context.

Is there a correct way to utilize ExecutableInvoker such that the context of the currently running test has access to that test's ParameterResolvers?