Introduce tooling support tests #1431
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1431 +/- ##
=========================================
Coverage 91.83% 91.83%
Complexity 3191 3191
=========================================
Files 295 295
Lines 7669 7669
Branches 652 652
=========================================
Hits 7043 7043
Misses 463 463
Partials 163 163Continue to review full report at Codecov.
|
| testImplementation(project(':junit-jupiter-api')) | ||
|
|
||
| testRuntimeOnly(project(':junit-platform-console-standalone')) { | ||
| because 'needed by Ant projects using native junitlauncher task' |
There was a problem hiding this comment.
Should not be on the test runtime classpath!
How do I declare that platform-tooling-support-tests depends on junit-platform-console-standalone library to be built?
|
|
||
| * New integration test sub-project `platform-tooling-support-tests` added. Set system | ||
| property `platform.tooling.support.tests.enabled` to `true` to activate it in the | ||
| main build process. |
There was a problem hiding this comment.
We usually don't include non user facing changes in the release notes.
| testImplementation('org.junit.jupiter:junit-jupiter-api:5.2.0') { | ||
| because 'needed to compile Jupiter tests // TODO use current junit-jupiter-api' | ||
| } | ||
| testImplementation('org.junit.jupiter:junit-jupiter-api:5.3.0-SNAPSHOT') |
There was a problem hiding this comment.
I think we should pass the current version from :platform-tooling-support-tests:test to these dependent builds, e.g. by using a system property.
There was a problem hiding this comment.
Aye. Already almost implemented ... locally.
Enable Gradle 4.7 test only on Java 10 and prevent Jenkins to mark successful builds as unstable by setting gradle projects buildDir to 'bin' instead of using the default 'build'.
System property 'platform.tooling.support.tests.enabled' must be set to 'true' in order to execute the integration tests.
Run tooling support tests after publishing to local maven repository.
sormuras
force-pushed
the
1429-platform-tooling-support-tests
branch
from
bb439f5
to
7114328
Compare
ghost
removed
the
Overview
Implements #1429 by creating
platform-tooling-support-testsproject and integrating it as an opt-in build step into the main build process. To activate the tests, passplatform.tooling.support.tests.enabled=trueas a system property.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations