Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package name comparison on Java 8 #4077

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Fix package name comparison on Java 8 #4077

merged 4 commits into from
Oct 17, 2024

Conversation

marcphilipp
Copy link
Member

@marcphilipp marcphilipp commented Oct 17, 2024 •
edited
Loading

Overview

I hereby agree to the terms of the JUnit Contributor License Agreement.

Definition of Done

@marcphilipp marcphilipp self-assigned this Oct 17, 2024
@marcphilipp marcphilipp linked an issue Oct 17, 2024 that may be closed by this pull request
Test discovery failing with NullPointerException when trying to find methods of a test class #4076
Closed
@marcphilipp marcphilipp force-pushed the marc/4076-fix-package-name-comparison branch from 226cb99 to 4ade611 Compare October 17, 2024 06:52
@marcphilipp marcphilipp marked this pull request as ready for review October 17, 2024 06:53
@marcphilipp marcphilipp enabled auto-merge (squash) October 17, 2024 07:06
@marcphilipp marcphilipp requested a review from a team October 17, 2024 07:06
sbrannen
sbrannen approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this one, @marcphilipp.

@marcphilipp marcphilipp merged commit 35d3dd7 into main Oct 17, 2024
15 checks passed
@marcphilipp marcphilipp deleted the marc/4076-fix-package-name-comparison branch October 17, 2024 09:49
marcphilipp added a commit that referenced this pull request Oct 17, 2024
@marcphilipp
Fix package name comparison on Java 8 (#4077)
a3192bd 
`Class.getPackage()` returns `null` for the default package on Java 8.
This is now handled by inspecting the fully qualified class name rather
than throwing a `NullPointerException`.

Fixes #4076.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@marcphilipp marcphilipp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test discovery failing with NullPointerException when trying to find methods of a test class
2 participants
@marcphilipp @sbrannen