📏 Fix spacing in themes #450
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1350d35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
on the abstract heading... that probably also applies to any FrontmatterPart not just Abstract and I think we might want to cut the padding but keep other styling. The article-theme is where I really saw the mismatch. |
rowanc1
reviewed
Aug 23, 2024
| @@ -16,7 +16,7 @@ export function Abstract({ | |||
| if (!content) return null; | |||
| return ( | |||
| <div className={className}> | |||
| <h2 id={id} className="mb-3 text-base font-semibold group"> | |||
| <h2 id={id} className="mb-3 text-base font-semibold group not-prose"> | |||
There was a problem hiding this comment.
Making this not-prose will change the font which is not ideal. Can we just add mt-0?
|
I think that we already have good alignment without this PR and could close @agoose77, I took care of alignment in with the toc/nav work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there are a couple of spacing problems right now in our themes:
abstractheading is padded:I think the
abstractheading should benot-prose, as we don't want to pad it. Do you agree @stevejpurves?As for
useThemeTop, it looks like a mistake that it's used in themainbody. So, I've removed it.