-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Enable RTD again #1129
📖 Enable RTD again #1129
Conversation
- npm run build | ||
- npm run --workspace packages/mystmd link | ||
- myst --version | ||
- cd docs && myst build --html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- cd docs && myst build --html | |
- cd docs && myst build --html --execute |
Last time it was suggested to use --execute
, but my understanding is that only affects the running of notebooks. For these issues it should not be relevant right? Is it also used in the mystmd pages?
Thanks @LecrisUT for reopening this. @choldgraf I think you turned off the preview on RTD, are you in a place to re-enable? |
I can do that but just want to make sure that we are ready to do it. If I enable it then GitHub will mark every PR as failing until the rtd job is re enabled. Do we want that now or do we want to wait until we are actively fixing this before doing so? |
Oh fair point. I can make a small page to redirect here that would be run on main and all other branches |
You can activate this branch in RTD without enabling the pull request build if you want. That way, this branch will be built on every commit on RTD... Getting an outcome similar to the PR builds. |
You can do this by generating this file as you want and saving it at the root of the HTML output directory. More at https://docs.readthedocs.io/en/stable/reference/robots.html |
It would not have the nice PR link to show it, and it would have to be on a new branch on the main repo, but that would work |
Signed-off-by: Cristian Le <[email protected]>
|
Signed-off-by: Cristian Le <[email protected]>
Let's keep this in draft so we can explore how to fix the RTD issues. Quick comment @rowanc1 can you keep the RTD project alive so that it can run on PRs. It is fine if it fails on main/other PRs due to a lack of
.readthedocs.yaml
file, it's just that it would be good to have it here so that we can explore all of the issues and potential solutions across themyst-theme
repo (i.e. open a similar branch there and pointpackages.json
to the repo branch where we can explore potential fixes)TODO:
@choldgraf Can you comment with a screenshot of this?
.html
files:myst-to-react
issueindex.html
is still brokenrobots.txt
myst-to-react
issueflyout
menu supportCloses #1133