Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansigray or ansigrey? #174

Closed
mgeier opened this issue Dec 18, 2015 · 2 comments
Closed

ansigray or ansigrey? #174

mgeier opened this issue Dec 18, 2015 · 2 comments
Labels
good first issue great for new contributors
Milestone

Comments

@mgeier
Copy link
Contributor

mgeier commented Dec 18, 2015

I don't know if this is ever used, but I happened to notice that in nbconvert you use "ansigrey":

'37': 'ansigrey',

'{0}h{0}e{0}l{0}l{0}o{0}'.format(TermColors.White) : '<span class="ansigrey">h</span><span class="ansigrey">e</span><span class="ansigrey">l</span><span class="ansigrey">l</span><span class="ansigrey">o</span><span class="ansigrey"></span>',

In the notebook package (whose CSS, I guess, is used in nbconvert), however, "ansigray" is used:
https://github.com/jupyter/notebook/blob/b10326e93c93a8f79589e963ae48bbaac285e2f1/notebook/static/base/js/utils.js#L219
https://github.com/jupyter/notebook/blob/932f85c7593b2eada7a2095bd1f30d3f6ea48115/notebook/static/notebook/less/ansicolors.less#L13

I guess both packages should use the same spelling, right?

@Carreau Carreau added the good first issue great for new contributors label Jan 5, 2016
@Carreau
Copy link
Member

Carreau commented Jan 5, 2016

hum... likely yes.

@mgeier
Copy link
Contributor Author

mgeier commented Jan 5, 2016

BTW, in the meantime I found out that this is actually used for the little hat symbol (^) that marks the column number in the tracebacks.

mgeier added a commit to mgeier/nbconvert that referenced this issue Feb 2, 2016
As a side effect, this fixes jupyter#174.
@minrk minrk added this to the 4.2 milestone May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue great for new contributors
Projects
None yet
Development

No branches or pull requests

3 participants