-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconnection to Gateway (form nb2kg) #5924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @oyvsyo - these changes look good. Just had one comment on the wording.
Once this is merged, we will want to apply this to applicable code in jupyter_server/gateway
as well. Are you able to make that contribution also?
Co-authored-by: Kevin Bates <[email protected]>
No worries - thanks! Go ahead and place this into DRAFT mode if it's going to be multiple days, otherwise, just ping back when you're ready. |
was able to reproduce a lost session and get EnterpriseGatewayApp logs listed below:
There are timings in power of two so that seems to work proper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Dvoiak - thank you. Please post a similar PR to jupyter_server when you can. (I believe you had confirmed that previously, but I no longer see that comment.)
Mirror logic from
jupyter/nb2kg#45
that implements an exponential backoff algorithm and retry count
limit to prevent too many false API calls in error trying to reconnect to an orphaned session
@kevin-bates @esevan Can we add it here?