-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle about dialog #6592
Restyle about dialog #6592
Conversation
Thanks @kostyafarber this looks good. I'm currently investigating the CI failure in #6579, will try to get it in before merging this PR. |
Update variable contList to contributorList Co-authored-by: Jeremy Tuloup <[email protected]>
@jtpio also I thought of perhaps making the links default to the orange highlight as in: I think it would look better than the purple as it is now. Also making the hover state over the url links the same grey as the dismiss button instead of the red, as in the current JuypterLite: I couldn't figure out how to make those changes 😞 but they could round out the design and make it look better I think. Just some thoughts! |
It's probably in one of the CSS classes, we could investigate in a follow-up PR how to improve it yes. |
Looks like the prettier failure is relevant (would need a lint pass): https://github.com/jupyter/notebook/actions/runs/3289225812/jobs/5420503955 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@kostyafarber if you feel like iterating on this don't hesitate to open a new PR, thanks! |
@jtpio thanks will do! |
@jtpio Hey sorry to be that guy but would you be able to add the |
Sure thing, done! |
Description
The purpose of the pull request is to improve upon the style of the help dialog in Jupyter Notebook #6552
The updated dialog is as below.