Enhancement: Added drop shadows to markdown, text, and tree views #6893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rielAsh24
changed the title
|
Thanks @rielAsh24 for working on this! |
jtpio
reviewed
May 30, 2023
Glad to contribute! |
|
bot please update playwright snapshots |
Adjusted drop shadows for tree view, markdown and text notebooks.
Tree View drop shadow values are in co-ordination with the others.
Adjusted main-panel padding to be responsive
Added data-format body selectors to the css
Re-wrote the media query for allowing responsiveness without a refresh
rielAsh24
force-pushed
the
fix_6781-Added_Drop-Shadows_Markdown_Text_Tree
branch
from
41f93e6 to
ed28e9c
Compare
|
bot please update playwright snapshots |
Thank you @jtpio for your encouragement and support. Was great working on this pull request! 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #6781 ,
MarkdownandTextviews had edges without drop shadow, unlike the notebooks.This fix works on adding the drop shadows to these views, and the
Treeview/File browser.jlpmUI Tests