Fix ANSI code for "bold" #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may not be that simple since leading zeros seem to be allowed ... |
likely true. you might want to change the RegularExpression: |
|
I'm planning to implement this similarly to jupyter/nbconvert#225 (basically porting it to JavaScript), but I don't know when I'll have the time. If somebody else wants to tackle this, go ahead! |
mgeier
added a commit
to mgeier/notebook
that referenced
this pull request
Mar 18, 2016
The implementation is based on Python code from nbconvert.filters.ansi2html(). Among other things, this fixes jupyter#988.
mgeier
added a commit
to mgeier/notebook
that referenced
this pull request
Mar 18, 2016
The implementation is based on Python code from nbconvert.filters.ansi2html(). Among other things, this fixes jupyter#988.
|
I've created #1230, which will resolve this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested, since I couldn't build the notebook locally.
However, there's a similar error in nbconvert, where changing
01to1fixes the problem.