Fix bugs when max_terminals reached, with test cases #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo fix for MaxTerminalsReached exception Handle cases where TermSocket.terminal not fully initialized
| @@ -225,7 +225,7 @@ def kill_all(self): | |||
| yield super(SingleTermManager, self).kill_all() | |||
| self.terminal = None | |||
|
|
|||
| def MaxTerminalsReached(Exception): | |||
There was a problem hiding this comment.
Ooops... I'm surprised that a class definition was a valid function definition, but now I think about it, there's nothing to make it invalid.
|
Thanks, this all looks fine, and the tests are passing. |
takluyver
added a commit
that referenced
this pull request
Feb 13, 2015
Fix bugs when max_terminals reached, with test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo fix for MaxTerminalsReached exception
Handle cases where TermSocket.terminal not fully initialized