Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jupyter server,
last_activity
is patched into ptywclients in handlerIf we close the browser or refresh it, these is no socket to update
last_activity
Also if we execute some time consuming terminal(like below),
last_activity
will not be updatedSo this PR introduces
pre_pty_read_hook
, which allows the jupyter server's TerminalManager to update the pty when it is readingin jupyter server (I will create a pr in jupyter server as well)