Revert pinging implementation, and call super method in websocket open #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for Jupyter mixin class to start websocket pinging
|
👍 to this for use in Jupyter. It does remove the feature for uses outside Jupyter. |
|
Right, but any application that wants to use it can copy the mixin class. The pinging is orthogonal to what you actually do with the websocket. Do you think it's worth sending the pinging code upstream to tornado? It sounds like a pretty general requirement. |
Yeah, probably a good idea. |
takluyver
added a commit
that referenced
this pull request
Feb 12, 2016
Revert pinging implementation, and call super method in websocket open
|
Is this commit actually in a release? We're still experiencing websocket timeouts with the terminado terminals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow terminals in Jupyter to use the websocket pinging implemented by a mixin class.
Ping @minrk @zyzhu2000