Make sure SIGPIPE has default handler set #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2021
|
This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there: https://discourse.jupyter.org/t/unexpected-broken-pipe-errors-in-the-jupyterlab-terminal/8297/6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When spawning individual servers in a way that has systemd as an ancestor somewhere up the process tree (e.g. using
SystemdSpawner), the server inherits systemd's default of ignoring SIGPIPE. This in turn means that if you start a terminal inside the individual server and run pipelines, you can come acrossBroken pipeerrors which you wouldn't normally see in an interactive shell that has default SIGPIPE handling:(See this post on the Jupyter Discourse for more details.)
The systemd-devel mailing list post linked in the first paragraph suggests that "Of course, shells and suchlike should turn this [i.e. SIGPIPE handling] on again." So this is what this PR does :) Let me know though if this should be handled somewhere else, I'm keen to follow through and do everything I can to have this fixed, as it affects my own setup and teaching.