Implement Undo & Redo keyboard shortcuts

[arjxn-py]

This is a rough try of me in which I tried to introduce simple keybindings for undo & redo i.e.

• Ctrl + z for undo
• Ctrl + y for redo

Summary of What I Did:

• Created keybindings.json in which I have defined keybindings for undo and redo.
• Loaded Keybindings inside Extension:
  • Modified the addCommands() function to load the keybindings.
  • Used a helper function loadKeybindings to register the keybindings with the command registry.

[github-actions]

👈 Launch a Binder on branch arjxn-py/JupyterCAD/undo-redo-keybindings

[arjxn-py]

I studied QuantStack/jupytergis#58, i limited the selector to be the jupytercad-panel for undo & redo. Need one opinion- having keybindings.json is better or defining those keybindings inside the script only?

Edit: I personally feel that having a keybindings.json file is good because it is more modular.

[martinRenou]

Edit: I personally feel that having a keybindings.json file is good because it is more modular.

Yep I think that looks good 👍🏽 Thanks

It looks like your PR is now conflicting with the main branch, due to the merge of the other PR

[arjxn-py]

Resolving this branch asap.

[arjxn-py]

If I define body as the selector, these keybindings enables for whole app.
It is fine in that case if we don't want to have key bindings irrespective of which component is focused.

[martinRenou]

Neat! Thanks a lot

[SylvainCorlay]

Arg. It seems the redo keyboard shortcut does not work.

[arjxn-py]

Hi @SylvainCorlay, I just tested these keyboard shortcuts locally and on https://jupytercad.github.io/JupyterCAD/ as well and it seems to be working as expected for me on both the places.

Screen.Recording.2024-08-02.232030.mp4

However on a sidenote, I'd like to mention that we had an issue with the redo function in the past, which has been fixed recently by #385, thanks to @trungleduc. So in case you're trying this out locally, I'd once suggest to make sure that the code is properly synced to upstream. But in case the issue still persists, please let us know about the same. Thanks a lot for following up on this, I'd be more than happy to assist further.

[SylvainCorlay]

Thanks for looking into it. The issue may be specific to the JupyterLite deployment.