Handle zoom while camera change #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Integration tests repot: appsharing.space |
|
Preview PR at appsharing.space |
martinRenou
reviewed
Oct 17, 2024
| @@ -1323,12 +1324,17 @@ export class MainView extends React.Component<IProps, IStates> { | |||
| const width = this.divRef.current?.clientWidth || 0; | |||
| const height = this.divRef.current?.clientHeight || 0; | |||
|
|
|||
| const distance = position.distanceTo(target); | |||
| const zoomFactor = 1000 / distance; | |||
There was a problem hiding this comment.
Do you know why we need this magic 1000 number?
There was a problem hiding this comment.
This is kind of an arbitrary number after some hit and trials, I noticed that more you zoom the object in PerspectiveCamera more further it goes on OrthographicCamera
There was a problem hiding this comment.
So it meant that the distance was inversely proportional to the zooming in that i needed to do
There was a problem hiding this comment.
Sounds good! I tested on my side and this seems to work well. We have other magic numbers in JupyterCAD
martinRenou
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoom.mov
Shall fix #483