Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Prevent tree from wrongly updating the selection #571

Merged

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Nov 7, 2024

Fix #560

Fix:

  • The tree was setting the wrong selection
  • The tree was updating the selection and re-rendering itself for each mouse move in the 3D view

This PR should prevent jumping selection and improve performance, hopefully.

@martinRenou martinRenou added the bug PR that fixes a bug label Nov 7, 2024
@martinRenou martinRenou force-pushed the tree_prevent_update_selection branch from 018c5e9 to 31d9f22 Compare November 7, 2024 17:31
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Preview PR at appsharing.space

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Integration tests report: appsharing.space

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit af996e5 into jupytercad:main Nov 7, 2024
10 checks passed
@martinRenou martinRenou deleted the tree_prevent_update_selection branch November 7, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selection state seems to jump between tree and mainview
2 participants