Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for rotated shape #583

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Conversation

arjxn-py
Copy link
Member

Related to #580

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Integration tests report: appsharing.space

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Preview PR at appsharing.space

@arjxn-py
Copy link
Member Author

Please update snapshots.

@arjxn-py
Copy link
Member Author

@martinRenou
Copy link
Member

Galata workflow failing

The galata workflow requires the build artifacts to be published before it can run, maybe that build was not done yet https://github.com/jupytercad/JupyterCAD/actions/runs/11911814236/job/33194119583?pr=583

I restarted the galata workflow

@martinRenou
Copy link
Member

Now it's still failing, but it fails just like in your PR with

Error: locator.click: Error: strict mode violation: locator('[data-test-id="react-tree-root"]').getByText('Cone') resolved to 2 elements:
        1) <span>Cone 1</span> aka getByText('Cone 1')
        2) <span>Cone 2</span> aka locator('[data-test-id="react-tree-root"]').getByText('Cone 2')

This seems to be a legit error

@arjxn-py
Copy link
Member Author

Please update snapshots

@martinRenou
Copy link
Member

Closing and reopening to trigger CI

@martinRenou martinRenou reopened this Nov 19, 2024
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Check-release is saying nonsense. Let's ignore

@martinRenou martinRenou merged commit b3b346a into jupytercad:main Nov 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants