Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stl and stp icons #591

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Add stl and stp icons #591

merged 5 commits into from
Nov 28, 2024

Conversation

IsabelParedes
Copy link
Contributor

Resolves #535

@IsabelParedes IsabelParedes marked this pull request as ready for review November 28, 2024 11:47
@martinRenou martinRenou added the enhancement New Feature or improvement label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Integration tests report: appsharing.space

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 28, 2024 •
edited
Loading

Preview PR at appsharing.space

@martinRenou
Copy link
Member

This is how it looks in practice:

Screenshot From 2024-11-28 12-53-49
Screenshot From 2024-11-28 12-53-57

@SylvainCorlay
Copy link
Member

Awesome!

I think that what is missing is the coloring of the icon in white when the item is selected in the file browser.

Screenshot 2024-11-28 at 13 18 42 Screenshot 2024-11-28 at 13 18 36 Screenshot 2024-11-28 at 13 18 28

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Nov 28, 2024 •
edited
Loading

It seems that the icon is missing from the tab handle.

Screenshot 2024-11-28 at 13 21 55

@martinRenou
Copy link
Member

Both mentioned issues should be fixed now 🚀

@martinRenou martinRenou merged commit 16cfba8 into jupytercad:main Nov 28, 2024
10 checks passed
@IsabelParedes IsabelParedes deleted the stl_stp branch November 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

Assignees
No one assigned
Labels
enhancement New Feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STL and STEP file icons
3 participants
@IsabelParedes @martinRenou @SylvainCorlay