Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings and roomPrefix #3

Merged
merged 7 commits into from
Apr 20, 2022
Merged

Add settings and roomPrefix #3

merged 7 commits into from
Apr 20, 2022

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Apr 16, 2022 •
edited
Loading

References

Code changes

  • adds plugin schema
    • make configurable roomPrefix instead of only host
  • SHA256 {prefix}-{room} for more obfuscation
  • adds translation hooks
  • adds webrtc icon
  • add "off switch" to command palette
  • adds a status bar item (as a separate plugin)
  • update docs about vendoring

User-facing changes

note shot
settings. text fields have known issues Screenshot from 2022-04-16 13-34-36
status bar indicator Screenshot from 2022-04-18 09-07-18

Backwards-incompatible changes

  • n/a

@github-actions
Copy link

Binder 👈 Launch a Binder on branch bollwyvl/jupyterlab-webrtc-docprovider/gh-2-settings

@bollwyvl bollwyvl added the enhancement New feature or request label Apr 16, 2022
@bollwyvl bollwyvl mentioned this pull request Apr 19, 2022
Closed
@bollwyvl bollwyvl merged commit d6f21d5 into jupyterlite:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make room prefix (and other aspects) configurable in settings
1 participant
@bollwyvl