chore: fix admin permission to create new omp #1747
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
gitanjli525
added
the
S-waiting-on-review
kanikabansal-juspay
previously approved these changes
Nov 18, 2024
sagarnaikjuspay
previously approved these changes
Nov 19, 2024
| | _ => [] | ||
| } | ||
|
|
||
| let hasCreateNewOMPAccess = (user, roleId): CommonAuthTypes.authorization => { |
There was a problem hiding this comment.
use hook instead of function
There was a problem hiding this comment.
okay @JeevaRamu0104
added 2 commits
November 26, 2024 16:32
…center into admin-permission-fix
gitanjli525
dismissed stale reviews from sagarnaikjuspay and kanikabansal-juspay
via
6545312
gitanjli525
requested review from
JeevaRamu0104,
kanikabansal-juspay and
sagarnaikjuspay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
currently merchant admins are able to click the button to create new merchant and profile admins are able to click on button to create new profiles, but the backend api throws error for the same as "Access Forbidden"
this PR disables the button click in these cases using the roleId that we are getting from user api response
Motivation and Context
How did you test it?
Where to test it?
Checklist
npm run re:build