feat(custodian): add support for authorization for accessing keys #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
requested changes
Oct 5, 2024
dracarys18
requested changes
Oct 7, 2024
| ) -> errors::CustomResult<DecryptedDataGroup, errors::CryptoError> { | ||
| let version = FxHashSet::from_iter(self.0.values().map(|d| d.version)); | ||
| let decrypted_keys = Key::get_multiple_keys(state, identifier, version) | ||
| .await | ||
| .switch()?; | ||
|
|
||
| let mut stored_tokens = decrypted_keys.values().map(|k| &k.token); |
There was a problem hiding this comment.
Suggested change
| let mut stored_tokens = decrypted_keys.values().map(|k| &k.token); | |
| let stored_tokens = decrypted_keys.values().map(|k| &k.token); |
There was a problem hiding this comment.
It's required, as it's a opaque type that will be acted upon: when we call .all on it
Chethan-rao
reviewed
Oct 7, 2024
|
Sure looks good to me, please test it once |
dracarys18
approved these changes
Oct 9, 2024
Chethan-rao
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding custodian support. Adding support for Basic authentication on top of mTLS, to make sure that the keys being accessed belong to the respective party.