Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users): Send welcome to community email in magic link signup #6639

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

ThisIsMani
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Magic link will send one more email along with magic link email if user is signing up.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #6638.

How did you test it?

Local SES
image

curl --location 'http://localhost:8080/user/connect_account' \
--header 'Content-Type: application/json' \
--data-raw '{
    "email": "new user email"
}'

The above email should be sent.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@ThisIsMani ThisIsMani added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-users Area: Users labels Nov 22, 2024
@ThisIsMani ThisIsMani self-assigned this Nov 22, 2024
@ThisIsMani ThisIsMani requested review from a team as code owners November 22, 2024 08:42
Copy link

semanticdiff-com bot commented Nov 22, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/user.rs  4% smaller
  crates/router/src/consts/user.rs  0% smaller
  crates/router/src/services/email/assets/welcome_to_community.html  0% smaller
  crates/router/src/services/email/types.rs  0% smaller

subject: consts::user::EMAIL_SUBJECT_WELCOME_TO_COMMUNITY,
};

let send_email_result = state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shadowing the variable.

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 03423a1 Nov 26, 2024
15 of 17 checks passed
@Gnanasundari24 Gnanasundari24 deleted the welcome-email branch November 26, 2024 09:10
@ThisIsMani ThisIsMani removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 26, 2024
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
bsayak03 pushed a commit that referenced this pull request Nov 26, 2024
)

Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(users): Send welcome to community email in magic link signup
5 participants