-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): Send welcome to community email in magic link signup #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMani
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-users
Area: Users
labels
Nov 22, 2024
Changed Files
|
racnan
reviewed
Nov 22, 2024
crates/router/src/core/user.rs
Outdated
subject: consts::user::EMAIL_SUBJECT_WELCOME_TO_COMMUNITY, | ||
}; | ||
|
||
let send_email_result = state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shadowing the variable.
racnan
approved these changes
Nov 22, 2024
SanchithHegde
approved these changes
Nov 22, 2024
gitanjli525
approved these changes
Nov 22, 2024
ThisIsMani
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Magic link will send one more email along with magic link email if user is signing up.
Additional Changes
Motivation and Context
Closes #6638.
How did you test it?
Local SES
The above email should be sent.
Checklist
cargo +nightly fmt --all
cargo clippy