feat(routing): Enable volume split for dynamic routing #6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hyperswitch into feat_elimination_routing
…tch into feat_elimination_routing
…tch into dynamo-volume-split
…hyperswitch into feat_elimination_routing
…hyperswitch into feat_elimination_routing
hyperswitch-bot
bot
added
M-database-changes
…tch into dynamo-volume-split
…f github.com:juspay/hyperswitch into dynamo-volume-split
…tch into dynamo-volume-split
hyperswitch-bot
bot
removed
M-database-changes
hyperswitch-bot
bot
added
the
M-api-contract-changes
hyperswitch-bot
bot
removed
the
M-api-contract-changes
Chethan-rao
requested changes
Dec 3, 2024
| @@ -1776,6 +1776,10 @@ impl Profile { | |||
| web::resource("/toggle") | |||
| .route(web::post().to(routing::toggle_elimination_routing)), | |||
| ), | |||
| ) | |||
| .service( | |||
| web::resource("/set_volume_split") | |||
There was a problem hiding this comment.
By just looking at the api-contract, client won't be aware that he is setting volume split for dynamic routing type right? Even the query param is just split
There was a problem hiding this comment.
this is scoped under /dynamic_routing
Chethan-rao
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Have added a new API for enabling volume split for dynamic routing service
Additional Changes
Motivation and Context
How did you test it?
Status in DB -
Checklist
cargo +nightly fmt --allcargo clippy