fix: JSONSchema generated forms for contexts #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShubhranshuSanjeev
force-pushed
the
fix/context-form
branch
2 times, most recently
from
25de1f1
to
d86f41d
Compare
sauraww
requested changes
Oct 22, 2024
| impl Operand { | ||
| pub fn from_operand_json(value: Value) -> Self { | ||
| match value { | ||
| Value::Object(ref o) if o.contains_key("var") => Operand::Dimension(value), |
There was a problem hiding this comment.
If ref required here ?
Can we remove it ?
There was a problem hiding this comment.
I want a reference.
ShubhranshuSanjeev
force-pushed
the
fix/context-form
branch
2 times, most recently
from
0cca50a
to
5346aa1
Compare
ShubhranshuSanjeev
changed the title
ShubhranshuSanjeev
force-pushed
the
fix/context-form
branch
from
641186c
to
90f420a
Compare
ShubhranshuSanjeev
force-pushed
the
fix/context-form
branch
2 times, most recently
from
0b7248b
to
533787b
Compare
ShubhranshuSanjeev
force-pushed
the
fix/context-form
branch
from
533787b
to
f6a3529
Compare
sauraww
requested changes
Nov 18, 2024
| Operands( | ||
| iter.into_iter() | ||
| .map(Operand::from_operand_json) | ||
| .collect::<Vec<Operand>>(), |
There was a problem hiding this comment.
Can we make a type for Vec as Operands as we made for Conditions ?
There was a problem hiding this comment.
Didn't really understand the point.
| let on_context_edit = Callback::new(move |data: (Context, Map<String, Value>)| { | ||
| let (context, overrides) = data; | ||
| let conditions = | ||
| Conditions::from_context_json(&context.condition.into()).unwrap(); |
There was a problem hiding this comment.
Can we avoid using plain unwrap here ?
| let on_context_clone = Callback::new(move |data: (Context, Map<String, Value>)| { | ||
| let (context, overrides) = data; | ||
| let conditions = | ||
| Conditions::from_context_json(&context.condition.into()).unwrap(); |
|
|
||
| open_drawer("context_and_override_drawer"); | ||
| }); | ||
| open_drawer("context_and_override_drawer"); |
There was a problem hiding this comment.
Can we create ENUMs for these strings , it's a little dangerous to keep it as strings
There was a problem hiding this comment.
Drawers are going away in my next PR, so this will be redundant work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change