feat: Use Common db model types in frontend #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushjain17
force-pushed
the
db_model_types_usage
branch
2 times, most recently
from
be305a6 to
90bcdaa
Compare
ayushjain17
force-pushed
the
db_model_types_usage
branch
2 times, most recently
from
731d855 to
1c372bd
Compare
ayushjain17
force-pushed
the
db_model_types_usage
branch
6 times, most recently
from
58c75da to
e7a9767
Compare
pratikmishra356
requested changes
Dec 16, 2024
| @@ -66,7 +66,38 @@ pub struct Dimension { | |||
| pub position: i32, | |||
| } | |||
|
|
|||
| #[derive(Serialize, Clone)] | |||
| #[derive(Debug, Clone, Serialize, Deserialize)] | |||
There was a problem hiding this comment.
I dont think these types should be in models , can we use some other file for these types which are not related to
the db table
| @@ -155,13 +158,51 @@ impl From<HashMap<String, String>> for QueryMap { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
| #[derive(Debug, Clone, PartialEq)] | |||
| pub struct PaginationParams { | |||
There was a problem hiding this comment.
these types shouldn't be in models file
ayushjain17
force-pushed
the
db_model_types_usage
branch
from
e7a9767 to
2b2b7e4
Compare
pratikmishra356
previously approved these changes
Dec 16, 2024
ayushjain17
force-pushed
the
db_model_types_usage
branch
3 times, most recently
from
bd5c3d8 to
576c6b7
Compare
ayushjain17
force-pushed
the
db_model_types_usage
branch
from
576c6b7 to
2937a97
Compare
ShreyBana
previously approved these changes
Dec 17, 2024
ayushjain17
dismissed stale reviews from ShreyBana and pratikmishra356
The base branch was changed.
ShreyBana
approved these changes
Dec 17, 2024
pratikmishra356
approved these changes
Dec 17, 2024
sauraww
pushed a commit
that referenced
this pull request
Dec 18, 2024
sauraww
pushed a commit
that referenced
this pull request
Dec 18, 2024
Datron
pushed a commit
that referenced
this pull request
Jan 2, 2025
Datron
pushed a commit
that referenced
this pull request
Jan 9, 2025
mahatoankitkumar
pushed a commit
that referenced
this pull request
Jan 21, 2025
Datron
pushed a commit
that referenced
this pull request
Jan 23, 2025
Datron
pushed a commit
that referenced
this pull request
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Types redefined in
frontendcrateSolution
Remove the repeated definitions from
frontendcrate and re-use types defined insuperposition_typesContinuation for this PR