fix: toggle default value #395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
approved these changes
Jan 31, 2025
ayushjain17
requested changes
Jan 31, 2025
| } | ||
| None => view! { <Toggle value=false on_change class name/> }.into_view(), | ||
| None => { | ||
| on_change.call(Value::Bool(false)); |
There was a problem hiding this comment.
this would get triggered on every re-render
this should be dealt at the moment when the type is being chosen by the user
ShubhranshuSanjeev
requested changes
Jan 31, 2025
| } | ||
| None => view! { <Toggle value=false on_change class name/> }.into_view(), | ||
| None => { | ||
| on_change.call(Value::Bool(false)); |
mahatoankitkumar
force-pushed
the
fix/toggle
branch
from
cee4169 to
612a44c
Compare
mahatoankitkumar
force-pushed
the
fix/toggle
branch
from
612a44c to
ee8e36b
Compare
ayushjain17
requested changes
Feb 3, 2025
| @@ -278,6 +278,9 @@ where | |||
| ) { | |||
| (Ok(schema_type), Ok(enum_variants)) => { | |||
| let input_type = InputType::from((schema_type.clone(), enum_variants)); | |||
| if input_type == InputType::Toggle { | |||
| config_value_ws.set(Value::Bool(false)); | |||
There was a problem hiding this comment.
this is also at render time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The toggle component defaults to null instead of a boolean value when initially rendered, causing unexpected behavior until user interaction occurs.
Solution
Called the onChange event handler to properly handle the initial null state, ensuring the toggle always has a valid boolean value (true/false).