feat: Discard experiment #398
Conversation
ayushjain17
force-pushed
the
exp/discard
branch
2 times, most recently
from
2ac0601 to
287b0ce
Compare
| .schema_name(&workspace_request.schema_name) | ||
| .get_result::<Experiment>(&mut conn)?; | ||
|
|
||
| if !experiment.status.is_active() |
There was a problem hiding this comment.
How about experiment.discardable()?
| .await | ||
| { | ||
| Ok(experiment) => { | ||
| log!("experiment response {:?}", experiment); |
There was a problem hiding this comment.
How about a debug log instead?
workspace_template.sql
Outdated
| @@ -450,3 +450,5 @@ VALUES ( | |||
| null, | |||
| 'variantIds are used by experimentation module to manage and select variations' | |||
| ); | |||
|
|
|||
| ALTER TYPE public.experiment_status_type ADD VALUE 'DISCARDED'; | |||
There was a problem hiding this comment.
No new line at the of file 😢
ayushjain17
force-pushed
the
exp/discard
branch
from
287b0ce to
e610199
Compare
ayushjain17
force-pushed
the
exp/discard
branch
from
e610199 to
d7d0033
Compare
ayushjain17
force-pushed
the
exp/discard
branch
from
d7d0033 to
8cd63dc
Compare
|
|
||
| view! { | ||
| <h3 class="font-bold text-lg">Discard Experiment</h3> | ||
| <p class="py-4">Safely discard the experiment without affecting any pre-existing overrides</p> |
| <textarea | ||
| placeholder="Enter a reason for this change" | ||
| class="textarea textarea-bordered w-full max-w-md" | ||
| value=change_reason.get_untracked() | ||
| on:change=move |ev| { | ||
| let value = event_target_value(&ev); | ||
| set_change_reason.set(value); | ||
| } | ||
| /> |
There was a problem hiding this comment.
Lets use the generic input component for this?
There was a problem hiding this comment.
@sauraww is making a generic component for description and reason, it is expected to be used here as well
| .await | ||
| { | ||
| Ok(experiment) => { | ||
| log!("experiment response {:?}", experiment); |
There was a problem hiding this comment.
nitpick:
| log!("experiment response {:?}", experiment); | |
| log!("experiment discard response {:?}", experiment); |
| let mut redirect_url = format!("admin/{org_id}/{tenant}/default-config"); | ||
| if let Some(prefix) = key_name { | ||
| redirect_url = format!("{redirect_url}?prefix={prefix}") | ||
| } |
There was a problem hiding this comment.
instead of mutation redirect_url, you could just overwrite it. Try this sample:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=049ec5fec47ae8a1253bd871838ed69a
| @@ -450,3 +450,5 @@ VALUES ( | |||
| null, | |||
| 'variantIds are used by experimentation module to manage and select variations' | |||
| ); | |||
|
|
|||
| ALTER TYPE public.experiment_status_type ADD VALUE 'DISCARDED'; | |||
There was a problem hiding this comment.
Can we add a failure catch here? This would fail in the future for schemas that already have this Value.
There was a problem hiding this comment.
why would this fail ?
this is anyways going to used only when a new workspace is going to be created, in which case, the type would not exist at all
Problem
No option to discard a created experiment
Solution
Allow discarding of experiment only when it is in created state
Environment variable changes
Needs update in
experiment_status_typeDB enumAPI changes
{change_reason: String}ExperimentResponse