feat: wrapper connection implementation #400
Open
+227
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A couple of things.
|
ShreyBana
reviewed
Jan 31, 2025
crates/service_utils/src/db/types.rs
Outdated
| use diesel::PgConnection; | ||
| use diesel::RunQueryDsl; | ||
|
|
||
| pub struct SuperTransactionManager; |
There was a problem hiding this comment.
How about TransactionManagerImpl?
crates/service_utils/src/db/types.rs
Outdated
| } | ||
| } | ||
|
|
||
| pub struct SuperConnection { |
| } | ||
| }; | ||
|
|
||
| let schema_name = req.extensions().get::<SchemaName>().cloned().unwrap().0; |
There was a problem hiding this comment.
We might have to update tenant.rs to insert superposition schema in case we want to add APIs for just querying things from those tables. I don't think we have that today.
|
I am seeing that we don't need the |
I can do the tests part if something is taking time. |
ShubhranshuSanjeev
force-pushed
the
feat/custom-connection
branch
from
fee97a0 to
007698a
Compare
ShubhranshuSanjeev
force-pushed
the
feat/custom-connection
branch
from
007698a to
c80c557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the problem you are trying to solve here
Solution
Provide a brief summary of your solution so that reviewers can understand your code
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
Things needed to be done before deploying this change (if any)
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change