verticalOffset prop #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds verticalOffset prop to fix bug with react-navigation header.
just4fun
reviewed
Dec 12, 2018
src/index.js
Outdated
| let { children, backgroundColor } = this.props; | ||
| let { children, backgroundColor, verticalOffset } = this.props; | ||
|
|
||
| //adds verticalOffset prop to bottom |
There was a problem hiding this comment.
Could you remove the comment? coz the name of the variable already explained its usage.
|
Could you please also update the doc? |
AlexisJamin
commented
Dec 12, 2018
JelteF
suggested changes
Dec 13, 2018
Co-Authored-By: AlexisJamin <[email protected]>
Closed
just4fun
reviewed
Dec 13, 2018
Updated doc with verticalOffset prop.
AlexisJamin
commented
Dec 13, 2018
just4fun
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds verticalOffset prop to fix bug with react-navigation header.